slachiewicz commented on PR #1088: URL: https://github.com/apache/maven-doxia/pull/1088#issuecomment-5528093244
Left to the implementor, explicitly. `Sink#unknown` says: > Adds an unknown event. This may be used by parsers to notify a general Sink about an event > that doesn't fit into any event defined by the Sink API. Depending on the parameters, a Sink > may decide whether or not to process the event, emit it as raw text, as a comment, log it, etc. "emit it as raw text, as a comment, log it" is an explicit grant of latitude, and the existing implementations already use all of it: `SinkAdapter` no-ops, `AptSink` logs and ignores, `Xhtml5BaseSink` reconstructs the tag. So moving `MarkdownSink` from log-and-drop to emitting the tag is a choice the contract allows rather than one it constrains. `MarkdownSink extends Xhtml5BaseSink`, so this PR delegates to that implementation rather than inventing its own interpretation, and only diverges where HTML5 forces it to (a self-closed non-void tag). *This comment was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
