michael-o commented on code in PR #1376:
URL: https://github.com/apache/maven-scm/pull/1376#discussion_r3924360619
##########
maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/main/java/org/apache/maven/scm/provider/svn/svnexe/command/SvnCommandLineUtils.java:
##########
@@ -124,8 +158,12 @@ public static Commandline getBaseSvnCommandLine(
public static int execute(Commandline cl, StreamConsumer consumer,
CommandLineUtils.StringStreamConsumer stderr)
throws CommandLineException {
- // SCM-482: force English resource bundle
- cl.addEnvironment("LC_MESSAGES", "en");
+ // ISSUE-1375: ensure that LC_ALL is unset to avoid locale issues with
svn command output parsing
+ // (setting just LC_ALL=C goes too far, since it would imply that
LC_CTYPE=C, which would cause
+ // svn to output non-ASCII chars in an unreadable way.)
+ // SCM-482: force English resource bundle (LC_MESSAGES was "en" before
ISSUE-1375)
+ cl.addEnvironment("LC_ALL", "");
+ cl.addEnvironment("LC_MESSAGES", "C");
Review Comment:
This looks incomplete and partially wrong:
* Does the empty arg really remove LC_ALL? What about other LC_*?
* This implies ASCII which will garble output
What you are loking for is:
https://github.com/freebsd/freebsd-ports/blob/620b30520f4f2574751e34131adaae56d417f2b3/Mk/bsd.port.mk#L995-L997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
