slachiewicz opened a new pull request, #3453:
URL: https://github.com/apache/maven-surefire/pull/3453

   ### Description
   In `ForkStarter#readTestClassNames`, `Files.readAllLines` was filtered using 
`String::isEmpty`, which inadvertently discarded all discovered test class 
names and retained only blank lines.
   
   When using toolchains or `forkCount > 1` / `reuseForks=false`, this resulted 
in zero tests being scheduled and the build passing silently without running 
any test classes.
   
   ### Changes
   - Changed `.filter(String::isEmpty)` to `.filter(line -> !line.isEmpty())` 
in `ForkStarter#readTestClassNames`.
   - Added a warning if the discovery file contains no test classes.
   - Added unit test 
`readTestClassNamesShouldKeepDiscoveredClassesAndDropBlankLines` in 
`ForkStarterTest`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to