slawekjaranowski commented on code in PR #445:
URL:
https://github.com/apache/maven-install-plugin/pull/445#discussion_r3898787274
##########
src/main/java/org/apache/maven/plugins/install/InstallMojo.java:
##########
@@ -163,19 +177,55 @@ public void execute() {
}
List<Project> projectsUsingPlugin = getProjectsUsingPlugin();
- if (allProjectsMarked(projectsUsingPlugin)) {
- for (Project reactorProject : projectsUsingPlugin) {
- State state = getState(reactorProject);
- if (state == State.TO_BE_INSTALLED) {
- Map<String, Object> pluginContext =
session.getPluginContext(reactorProject);
- ArtifactInstallerRequest request =
- (ArtifactInstallerRequest)
pluginContext.get(ArtifactInstallerRequest.class.getName());
- installProject(request);
+ synchronized (DEFERRED_INSTALL_LOCK) {
+ if (allProjectsMarked(projectsUsingPlugin)) {
+ List<Project> installedProjects = new ArrayList<>();
+ for (Project reactorProject : projectsUsingPlugin) {
+ State state = getState(reactorProject);
+ if (state == State.TO_BE_INSTALLED) {
+ Map<String, Object> pluginContext =
session.getPluginContext(reactorProject);
+ ArtifactInstallerRequest request =
+ (ArtifactInstallerRequest)
pluginContext.get(ArtifactInstallerRequest.class.getName());
+ try {
+ installProject(request);
Review Comment:
In master branch we build request wich contains all artifacts from all
projects, and finally `repositorySystem.install` is called only once, so we
resolver take care about install all artifacts
##########
src/main/java/org/apache/maven/plugins/install/InstallMojo.java:
##########
@@ -163,19 +177,55 @@ public void execute() {
}
List<Project> projectsUsingPlugin = getProjectsUsingPlugin();
- if (allProjectsMarked(projectsUsingPlugin)) {
- for (Project reactorProject : projectsUsingPlugin) {
- State state = getState(reactorProject);
- if (state == State.TO_BE_INSTALLED) {
- Map<String, Object> pluginContext =
session.getPluginContext(reactorProject);
- ArtifactInstallerRequest request =
- (ArtifactInstallerRequest)
pluginContext.get(ArtifactInstallerRequest.class.getName());
- installProject(request);
+ synchronized (DEFERRED_INSTALL_LOCK) {
+ if (allProjectsMarked(projectsUsingPlugin)) {
+ List<Project> installedProjects = new ArrayList<>();
+ for (Project reactorProject : projectsUsingPlugin) {
+ State state = getState(reactorProject);
+ if (state == State.TO_BE_INSTALLED) {
+ Map<String, Object> pluginContext =
session.getPluginContext(reactorProject);
+ ArtifactInstallerRequest request =
+ (ArtifactInstallerRequest)
pluginContext.get(ArtifactInstallerRequest.class.getName());
+ try {
+ installProject(request);
Review Comment:
In 3.x branch we build request wich contains all artifacts from all
projects, and finally `repositorySystem.install` is called only once, so we
resolver take care about install all artifacts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
