elharo commented on code in PR #3408:
URL: https://github.com/apache/maven-surefire/pull/3408#discussion_r3895452940
##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java:
##########
@@ -621,25 +621,26 @@ private static void getTestProblems(
private static void createOutErrElements(
OutputStreamWriter outputStreamWriter, XMLWriter ppw,
WrappedReportEntry report, OutputStream fw)
throws IOException {
- EncodingOutputStream eos = new EncodingOutputStream(fw);
- addOutputStreamElement(outputStreamWriter, eos, ppw,
report.getStdout(), "system-out");
- addOutputStreamElement(outputStreamWriter, eos, ppw,
report.getStdErr(), "system-err");
+ addOutputStreamElement(outputStreamWriter, ppw, report.getStdout(),
"system-out", fw);
+ addOutputStreamElement(outputStreamWriter, ppw, report.getStdErr(),
"system-err", fw);
}
private static void addOutputStreamElement(
OutputStreamWriter outputStreamWriter,
- EncodingOutputStream eos,
XMLWriter xmlWriter,
Utf8RecodingDeferredFileOutputStream
utf8RecodingDeferredFileOutputStream,
- String name)
+ String name,
+ OutputStream fw)
Review Comment:
what's fw? don't use abbreviations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
