gnodet opened a new pull request, #2078:
URL: https://github.com/apache/maven-resolver/pull/2078
## Summary
Follow-up fixes for PR #2060 (Fix #2058: Add links to configuration page),
discovered during a thorough review:
- **Fix `visitLink` label rendering** — The `visitLink` method in
`ConfigurationCollectorDoclet` was rendering `node.getReference()` (the link
target) instead of `node.getLabel()` (the explicit label text). For `{@link
Type custom label}`, this would display "Type" instead of "custom label". While
current configuration sources don't use explicit labels, this is a correctness
bug that would silently discard author-specified labels.
- **Replace Markdown emphasis with HTML `<em>` for deprecated content** —
The `configuration.md.vm` template wrapped HTML deprecated content (which may
contain `<a>`, `<code>` tags) in Markdown emphasis markers (`*...*`). This
mixes Markdown and HTML in a way that could break if the deprecated message
contains a literal `*` character, or confuse some Markdown renderers with HTML
tags inside emphasis markers. Now uses `<em>` for consistent HTML-only markup.
- **Add missing trailing newline** to `package-info.java` test fixture
(POSIX convention).
## Test plan
- [x] Added test assertion verifying explicit link labels are rendered
correctly (`{@link SampleType custom label text}` → `<a href="..."><code>custom
label text</code></a>`)
- [x] Updated existing test assertion for the `<em>` change in rendered
markdown
- [x] All 9 existing tests pass
- [x] Full build with configuration page generation succeeds
- [x] Generated `configuration.md` verified: internal apidocs/ links,
external docs.oracle.com links, and deprecated styling all render correctly
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
