[
http://jira.codehaus.org/browse/SUREFIRE-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_122487
]
Dan Fabulich commented on SUREFIRE-445:
---------------------------------------
There's really two separate changes in here: one of them is to just add the
Manifest-Version attribute, which is a one-line fix to ForkConfiguration. I've
committed that line fix in revision 618784.
The other change is to make ManifestJarWriter use java.util.jar.Manifest; that
makes sense, but I find it a bit spooky, so I've filed it separately as bug
SUREFIRE-451.
If you find you're still having problems after just fixing the
Manifest-Version, please comment on SUREFIRE-451. (Notably, I find that the
difference between the two is that java.util.jar.Manifest creates a manifest
with TWO final newlines; ManifestJarWriter as-is currently creates a manifest
with just ONE final newline.
> Surefire-Booter Manifest not correct
> ------------------------------------
>
> Key: SUREFIRE-445
> URL: http://jira.codehaus.org/browse/SUREFIRE-445
> Project: Maven Surefire
> Issue Type: Bug
> Affects Versions: 2.4
> Reporter: Joerg Lauer
> Attachments: sources.zip, surefire-booter-patch.diff
>
>
> The manifest of the jar file created by the surefire-booter seems to be
> written incorrectly. For one, it is missing the Manifest-Version, which
> according to the spec is required.
> I noticed because some tests were failing to be executed only for specific
> users. I have so far been unable to find the exact problem. But after
> patching the ManifestWriter to use the java.util.jar packages and the
> ForkConfiguration and ManifestWriterTest to set the Manifest-Version it seems
> to work fine.
> I have attached the diff and the complete source code for the three patched
> classes to this issue.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
