slawekjaranowski commented on code in PR #1102:
URL:
https://github.com/apache/maven-compiler-plugin/pull/1102#discussion_r3866257564
##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -1605,81 +1616,6 @@ private static List<String>
removeEmptyCompileSourceRoots(List<String> compileSo
return newCompileSourceRootsList;
}
- /**
- * We just compare the timestamps of all local dependency files
(inter-module dependency classpath) and the own
- * generated classes and if we got a file which is >= the build-started
timestamp, then we caught a file which
- * got changed during this build.
- *
- * @return {@code true} if at least one single dependency has changed.
- */
- protected boolean isDependencyChanged() {
Review Comment:
I'm not sure if we need to preserve all plugin internal methods.
Maven plugin is not library so should be not used as standard dependencies.
Even more we only recommended use as plugin not dependencies
https://maven.apache.org/plugins/maven-compiler-plugin/dependency-info.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
