Copilot commented on code in PR #405: URL: https://github.com/apache/maven-help-plugin/pull/405#discussion_r3753475190
########## src/it/projects/effective-pom-packaging/verify.groovy: ########## @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +def buildLog = new File(basedir, 'build.log'); +assert buildLog.exists() + +def LS = System.getProperty("line.separator") +assert buildLog.text.find( + '(?s)' + + ' <packaging>jar</packaging>') != null Review Comment: `LS` is declared but not used. Either remove it or incorporate it into the regex (as done in other IT verify scripts) so the test is consistent and avoids dead code. ########## src/main/java/org/apache/maven/plugins/help/EffectivePomMojo.java: ########## @@ -197,6 +197,16 @@ private void writeEffectivePom(MavenProject project, XMLWriter writer) throws Mo // This removes the XML declaration written by MavenXpp3Writer String effectivePom = prettyFormat(sWriter.toString(), null, true); + // MavenXpp3Writer omits packaging when it is null or "jar" (the default). + // Ensure it is always present so users can see the effective packaging value. + if (pom.getPackaging() == null || "jar".equals(pom.getPackaging())) { + String packaging = pom.getPackaging() != null ? pom.getPackaging() : project.getPackaging(); + String packagingTag = " <packaging>" + packaging + "</packaging>"; + if (!effectivePom.contains(packagingTag)) { + effectivePom = effectivePom.replace("</version>" + LS, "</version>" + LS + packagingTag + LS); + } + } Review Comment: `String#replace` will replace *every* occurrence of `</version>` in the effective POM, not just the project’s `<version>` element. Since effective POMs typically contain many `<version>` elements (parent, dependencies, plugins, etc.), this can insert `<packaging>` in multiple locations and produce invalid XML. Consider parsing the generated XML and inserting `<packaging>` only as a direct child of the root `<project>` element when it is missing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
