slachiewicz opened a new pull request, #915:
URL: https://github.com/apache/maven-wagon/pull/915
Forward-port of #904, which landed on `wagon-3.x`. master never got it, so
the two
lines differ on their test coverage -- and #903, the master half of the JSch
fork
change, has no harness to be verified against. **This should go in before
#903**,
the same way #904 went in before #902.
The `-Dssh-tests` suite has been dead for years. Three faults kept the
embedded
Apache MINA sshd tests from passing:
* `ShellCommand` flushed the channel output stream *after*
`ExitCallback.onExit`,
which closes it, tearing down the session so the command after every
`executeCommand` failed with "session is down". master still had that stray
flush -- it was the one cherry-pick conflict.
* The expected modification time on a get was compared at millisecond
precision,
but the scp `T` header carries whole seconds.
* The SFTP subsystem was not registered on the embedded server, so
wagon-ssh-external, which shells out to the host `scp`, could not connect
at all
under OpenSSH 9+.
`ScpWagon` now maps a missing file to `ResourceDoesNotExistException` for
the scp
fatal-error code (2) as well as the warning code (1) OpenSSH uses.
### Smaller than the 3.x version, deliberately
#904 also had to hand-supply a `TestPrompter` and a test component
descriptor:
plexus-interactivity-api stopped shipping `META-INF/plexus/components.xml`
in 1.3,
and `plexus-container-default` could see neither the sisu index nor
`DefaultPrompter`'s constructor injection.
Since #911 these tests run on the Sisu shim, which reads that index and
satisfies
the constructor, so the real `DefaultPrompter` resolves on its own. I
dropped the
workaround and re-ran: **42 tests, 0 failures** without it. That is two
files this
branch does not need to carry.
Full reactor green, plus `-Dssh-tests -Dssh-embedded=true`: 42 tests, 0
failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
