gnodet opened a new pull request, #2047:
URL: https://github.com/apache/maven-resolver/pull/2047
## Summary
- Commit 89f2bc1b ("Extend re-entrancy detection for broken trace chains")
added three new test methods in `DefaultRepositorySystemReentrancyTest` that
construct `DefaultRepositorySystemValidator` using
`Collections.singletonList(EXPRESSION_REJECTING_VALIDATOR_FACTORY)`
- However, commit f164aa90 ("Allow validator factory to abstain", #2008)
changed the constructor from `List<ValidatorFactory>` to `Map<String,
ValidatorFactory>`
- This causes a compilation failure on **all 18 CI jobs** (every OS × JDK ×
Maven combination): `incompatible types: no instance(s) of type variable(s) T
exist so that java.util.List<T> conforms to
java.util.Map<java.lang.String,org.eclipse.aether.spi.validator.ValidatorFactory>`
The fix replaces `Collections.singletonList(...)` with
`Collections.singletonMap("expressionRejecting", ...)` at all three call sites
(lines 361, 398, 457), consistent with the existing correct usage at line 174.
## Test plan
- [x] `mvn -pl maven-resolver-impl test-compile` compiles successfully
- [x] `mvn -pl maven-resolver-impl test
-Dtest=DefaultRepositorySystemReentrancyTest` — all 11 tests pass
- [ ] CI should go green
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
