elharo commented on PR #177: URL: https://github.com/apache/maven-resolver-ant-tasks/pull/177#issuecomment-5204435196
Fixed the CI failures. `testFindGlobalSettingsFallsBackToAntEtc` and `testFindGlobalSettingsReturnsNullWhenNotFound` were not hermetic: on the CI runner the Maven wrapper sets `MAVEN_HOME`/`maven.home`, so the new fallback correctly resolved the real `conf/settings.xml`. - Added a package-private `findGlobalSettings(Project, Map<String, String>)` overload that takes the environment explicitly; the public `findGlobalSettings(Project)` delegates with `System.getenv()`. - The affected tests now call the overload with an empty environment map, so they no longer depend on the ambient environment. - Verified locally both with and without the `maven.home` system property set; `mvn verify` passes (63 tests). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
