goutamadwant opened a new pull request, #12684:
URL: https://github.com/apache/maven/pull/12684
Fixes #10379.
When Maven rebuilds a consumer POM, `BUILD_CONSUMER` does not reactivate the
profiles that were active while building the project. As a result, model
validation can see unresolved dependency versions when their values come from
an active profile.
This change makes properties from the project's already-active profiles
available while rebuilding the consumer model. Session user properties are
applied afterward so their existing precedence is preserved. The change does
not activate additional profiles or replace profile-backed expressions in the
generated consumer POM.
A Core IT covers an `activeByDefault` profile that supplies a dependency
version and verifies that installation succeeds while the generated consumer
POM retains both the profile and the property expression.
### Tests
- `mvn -pl impl/maven-core -Dtest=ConsumerPomBuilderTest test`
- `mvn -Prun-its -DmavenHome=<maven-under-test>
-Dtest=MavenITmng8709ProfileDependencyVersionTest
-Dsurefire.failIfNoSpecifiedTests=false verify`
- `mvn -Prun-its -DmavenHome=<maven-under-test> verify -rf :core-it-suite`
on JDK 21
- 1,037 tests ran and the MNG-8709 regression passed. One unrelated
existing test failed because it expected the legacy Central URL
`https://repo1.maven.org` while the local environment used
`https://repo.maven.apache.org`.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in
other changes.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
Note that commits might be squashed by a maintainer on merge.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [x] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
