kratos0718 commented on PR #319: URL: https://github.com/apache/maven-source-plugin/pull/319#issuecomment-5199374187
Closing — #316 was already open for this and I missed it before starting. Apologies for the duplicate noise. For whatever it is worth, the one thing here that is not in #316 is that the existing `test-jar` IT passes either way today, since it only generates sources in `generate-sources`. #316 adds a separate `test-jar-generate-test-sources` IT, which covers the fix; extending the existing one as well would also stop it silently agreeing with a future regression. Entirely your call whether that is worth a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
