adityaanikam opened a new pull request, #201:
URL: https://github.com/apache/maven-script-interpreter/pull/201
## What / why
Groovy's `CompilerConfiguration` defaults its target bytecode to whatever
JDK is currently
running it (`defaultTargetBytecode()` reads the running JVM's version), with
no way to override
it. This means `verify.groovy` hook scripts get compiled to the executing
JDK's bytecode level
regardless of the project's own `maven.compiler.release`, which breaks old
source revisions as
the JDK running the build evolves. See apache/maven-invoker-plugin#742 for
the full report.
This PR adds a `setTargetBytecode(String)` method through the interpreter
stack:
- `ScriptInterpreter` gets a default no-op method (interpreters like
BeanShell that don't compile
to a bytecode level can ignore it).
- `GroovyScriptInterpreter` implements it, storing the value and applying it
to the
`CompilerConfiguration` used in `evaluateScript()`. A small
`normalizeTargetBytecode` helper
maps Maven-style release values (`"8"`) to the form Groovy's
`setTargetBytecode` expects
(`"1.8"` for JDK 4-8, bare numbers from JDK 9 on).
- `ScriptRunner` exposes the same setter, applying it to all registered
interpreters.
This only adds the capability to `maven-script-interpreter`. Wiring
`maven-invoker-plugin` to
read `maven.compiler.release` and call this new setter is a separate
follow-up PR against that
repo, since it depends on this change being available.
- [x] Your pull request should address just one issue, without pulling in
other changes.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
Note that commits might be squashed by a maintainer on merge.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [x] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its
verify`).
(N/A — this repo has no `run-its` profile or integration-test suite.)
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an Apache Individual Contributor
License Agreement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
