slachiewicz commented on issue #12676:
URL: https://github.com/apache/maven/issues/12676#issuecomment-5184289162

   ## Results from turning on Maven 4 verification
   
   Eight of the ten merged green, so those plugins build and test clean on 
4.0.0-rc-6 with no changes: maven-acr-plugin#144, maven-toolchains-plugin#192, 
maven-scripting-plugin#80, maven-doap-plugin#164, 
maven-project-info-reports-plugin#645, maven-remote-resources-plugin#288, plus 
the two consistency fixes maven-resources-plugin#502 and maven-jar-plugin#576. 
maven-war-plugin#644 and maven-checkstyle-plugin#677 are still running.
   
   Two turned up genuine Maven 4 problems. In both cases the failure is 
**only** on the `4.0.0-rc-6` matrix cell — the Maven 3 cells that completed 
passed, and fail-fast cancelled the remainder. Neither is caused by the 
workflow change; it just made them visible, which was the point.
   
   ### maven-gpg-plugin#330 — the build POM gets signed
   
   IT `sign-release-with-excludes`, 12 passed / 1 failed:
   
   ```
   java.lang.Exception: Unexpected file
     
target/local-repo/org/apache/maven/its/gpg/srwe/test/1.0/test-1.0-build.pom.asc
   ```
   
   Maven 4 installs both a consumer POM and a `build.pom`. The plugin signs the 
build POM too, so a `-build.pom.asc` appears that the IT's expected-file list — 
written before Maven 4 — does not know about.
   
   Two readings, and it is worth someone deciding which:
   
   - the IT simply needs to learn about Maven 4's dual-POM install, or
   - signing the build POM is wrong. It is an internal artifact rather than 
something consumers resolve, so a signature for it may not belong in the 
repository at all.
   
   The second is the more interesting possibility and should be settled before 
GA, since it affects what every released artifact looks like.
   
   ### maven-shade-plugin#837 — uber jar missing under Maven 4
   
   IT `MSHADE-374_testJarArtifactSet`, 83 passed / 1 failed:
   
   ```
   java.nio.file.NoSuchFileException:
     target/it/MSHADE-374_testJarArtifactSet/uber/target/mshade-374-uber-1.0.jar
   ```
   
   The uber jar is not produced. That IT covers `artifactSet` with a test-jar 
specifically, so artifact selection behaving differently under Maven 4 is the 
more likely cause than anything in the shading itself. Not diagnosed further.
   
   Both PRs are being left open with the failures on record, rather than 
reverted — the red cell is the finding.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to