slachiewicz opened a new pull request, #1350:
URL: https://github.com/apache/maven-javadoc-plugin/pull/1350
The plugin is currently only verified against Maven 3. Adding
`maven4-enabled: true` makes the shared verify workflow put the Maven 4 version
into the build matrix alongside `3.10.0-rc-1`, so regressions under Maven 4
show up here instead of downstream. The shared workflow adds the `jdk: 8` /
Maven 4 exclusion by itself, so nothing else has to change in the matrix.
The trailing comma in `matrix-exclude` has to go at the same time. Without
`maven4-enabled` that value is echoed verbatim, so the invalid JSON went
unnoticed; with the flag on, the shared workflow pipes it through `jq` to
append its own exclusion, and `jq` rejects it:
```
$ echo "$matrix_exclude" | jq -c '. + [{"jdk":"8","maven":"4.0.0-rc-6"}]'
jq: parse error: Expected another array element at line 7, column 7
```
Verified locally with Maven 4.0.0-rc-6 on JDK 21: `clean verify` succeeds
and all unit tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
