slachiewicz commented on PR #315: URL: https://github.com/apache/maven-source-plugin/pull/315#issuecomment-5181025215
Closing in favour of #268, which I had not spotted — it is the same upgrade, opened in January and refreshed today, and it should have precedence. For the record, the two overlap almost entirely: `mavenVersion` to rc-6, `maven-api-meta` → `maven-api-annotations`, `maven-archiver` moving to `org.apache.maven.shared`, the `ProjectManager`/`SourceRoot` migration, the workflow pin, and the `MSOURCES-140` assertion. #268 also bumps the parent POM 47 → 49 and the plugin-plugin / plugin-testing versions, which mine did not. Two small things here are not in #268, if they are wanted: 1. `src/site/site.xml` still carries a `<skin>` workaround whose own comment says it is only needed on beta-3 and is redundant from rc-5 onwards. Removing it is a clean follow-up now that the build is on rc-6. 2. `AbstractSourcePluginTestCase` still imports `org.apache.maven.api.plugin.testing.MojoExtension.getBasedir`. That compiles, because the deprecated shims are still there, but `MojoExtension` in rc-6 only honours the relocated annotations — see apache/maven#12678, where the same thing silently broke maven-jar-plugin. Worth moving to `org.apache.maven.testing.plugin` while touching these files. Happy to send either as a separate PR against master once #268 lands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
