slachiewicz commented on code in PR #500:
URL:
https://github.com/apache/maven-resources-plugin/pull/500#discussion_r3712533385
##########
src/main/java/org/apache/maven/plugins/resources/TestResourcesMojo.java:
##########
@@ -62,7 +62,12 @@ public class TestResourcesMojo extends ResourcesMojo {
* {@inheritDoc}
*/
public void execute() throws MojoException {
- if (skip) {
+ // isSkip() reads ResourcesMojo's own field. Both classes declare a
private
+ // "skip", so the two collapse into a single descriptor parameter and
the
+ // configurator writes the superclass one, leaving this class's field
false
+ // however the build configured <skip>. Reading both is what makes
+ // <skip>true</skip> reach this goal at all.
+ if (skip || isSkip()) {
Review Comment:
Yes, exactly — thanks, I had not spotted that PR. Added a `TODO` at that
line pointing at apache/maven#12626, so the workaround carries the condition
for its own removal: once that fix is in a release the configurator writes this
class's own field and the `isSkip()` half can go.
Keeping the workaround for now since it makes `MRESOURCES-131` pass on the
currently released Maven — the IT has been failing since 4.0.0-rc-5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
