slachiewicz commented on PR #1714: URL: https://github.com/apache/maven-mvnd/pull/1714#issuecomment-5177972643
Thanks — the three synced properties were right and are now all in: `slf4j.version` 2.0.18, `maven.resolver.version` 2.0.21, `jline.version` 4.3.1, plus the `jline-terminal-jansi` → `jansi-core` rename in `dependencyManagement` and the removal of the dead `<jansi.version>` (nothing in the tree references it). Confirmed against the rc-6 distribution itself: `jansi-core-4.3.1.jar` is present, there is no `jline-terminal-jansi` jar, and resolver/slf4j are at 2.0.21/2.0.18. On #1696 superseding this one — I do not think it does, on three counts: - it sets `maven.version` to `4.0.0-SNAPSHOT` (plus `apache-snapshots` `<repositories>`/`<pluginRepositories>` blocks), not the released `4.0.0-rc-6`. Its title says "upcoming rc-6" — it was written on 27 July, before rc-6 existed. - it does not touch `.mvn/wrapper/maven-wrapper.properties`, so the repo would still build *itself* with rc-5 while targeting rc-6. - it is a draft, `mergeable: false` / `rebaseable: false` against a base from a week ago (it diffs from jline 3.30.13 and resolver 2.0.18, whereas master is now on 3.30.16 and 2.0.20), and it has no CI runs at all. Happy to be overruled if the intent is to track `4.0.0-SNAPSHOT` rather than pin the release — but in that case the wrapper still needs updating separately. One note on the remaining red: the GraalVM `Build native distribution` jobs fail on master too (run 30862194274 on 67d0a23d, `undefined reference to stat@GLIBC_2.17` on ubuntu-24.04-arm), so that failure is not from this PR. #1712 is the fix for that one. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
