ctubbsii commented on code in PR #587: URL: https://github.com/apache/maven-apache-parent/pull/587#discussion_r3693434621
########## pom.xml: ########## Review Comment: By not changing either of those properties, the default behavior when people use this parent POM is that executions of rat will not work. Users will have to choose one of: 1. Override `minimalJavaBuildVersion` to at least 17 so that rat works, OR 2. Revert to an older Apache parent POM and manually update all the plugin versions that are managed by the parent POM with local overrides. Option 1 is basically what I'm suggesting doing anyway. Option 2 is a terrible option. My preference is that the `minimalJavaBuildVersion` default be updated to 17 in this PR, because that's the version that is required for all the plugins specified in this POM to actually work. So, it makes sense. Users don't have to update to this version of the parent POM, but those who choose to, but also want to build on an older JDK would only need to override this property, and the version properties for the rat plugin, which is much less effort than Option 2. There is a third option: 3. The rat plugin maintainers can revert the changes they made to require Java 17 (these are relatively few), and release an update that works with Java 8. I don't see a reason for them to do that, though. Java 8 is so old at this point, and there's no reason to build with it, since newer JDKs build Java 8 code just fine, provided the `maven.compiler.release` property is properly set, as this POM does for them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
