gnodet commented on code in PR #12651: URL: https://github.com/apache/maven/pull/12651#discussion_r3690998340
########## maven-core/src/main/java/org/apache/maven/plugin/internal/PluginDescriptorRequirementsValidator.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.plugin.internal; + +import javax.inject.Inject; +import javax.inject.Named; +import javax.inject.Singleton; + +import org.apache.maven.execution.MavenSession; +import org.apache.maven.plugin.PluginValidationManager; +import org.apache.maven.plugin.descriptor.MojoDescriptor; +import org.codehaus.plexus.component.configurator.expression.ExpressionEvaluator; +import org.codehaus.plexus.configuration.PlexusConfiguration; + +import static java.util.Objects.requireNonNull; + +/** + * Verify that plugin descriptor does not contain Plexus Component requirements. + */ Review Comment: Nit: Other validators in this package include `@since` tags (e.g., `DeprecatedCoreExpressionValidator` has `@since 3.9.1`). Consider adding one here: ```suggestion /** * Verify that plugin descriptor does not contain Plexus Component requirements. * * @since 3.10.0 */ ``` ########## maven-core/src/main/java/org/apache/maven/plugin/internal/PluginDescriptorRequirementsValidator.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.plugin.internal; + +import javax.inject.Inject; +import javax.inject.Named; +import javax.inject.Singleton; + +import org.apache.maven.execution.MavenSession; +import org.apache.maven.plugin.PluginValidationManager; +import org.apache.maven.plugin.descriptor.MojoDescriptor; +import org.codehaus.plexus.component.configurator.expression.ExpressionEvaluator; +import org.codehaus.plexus.configuration.PlexusConfiguration; + +import static java.util.Objects.requireNonNull; + +/** + * Verify that plugin descriptor does not contain Plexus Component requirements. + */ +@Singleton +@Named +class PluginDescriptorRequirementsValidator implements MavenPluginConfigurationValidator { + + protected final PluginValidationManager pluginValidationManager; + Review Comment: Nit: This field is `protected` but `PluginDescriptorRequirementsValidator` is a concrete, package-private, final class with no subclasses. The `protected` visibility on the abstract base class makes sense (subclass access), but here `private` would be more appropriate. ```suggestion private final PluginValidationManager pluginValidationManager; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
