wilx opened a new pull request, #832:
URL: https://github.com/apache/maven-shade-plugin/pull/832
Fixes #572.
## Summary
Preserve Groovy extension-module descriptors that declare only instance
extension classes or only static extension classes.
Groovy permits either extension category to be empty. The
`GroovyResourceTransformer` previously reported a transformed resource only
when both categories were populated. Shade had already consumed the original
descriptor by that point, so it wrote neither the original descriptor nor an
aggregated replacement.
The transformer now reports output when either category contains extension
classes. A new MSHADE-368 integration test shades the real
`groovy-sql:3.0.0` artifact and verifies that its instance-only extension
descriptor and implementation class survive in the shaded JAR.
## Tests
* `mvn -Prun-its clean verify`
* 72 unit tests passed;
* 84 integration projects passed; and
* two JRE-gated integration projects were skipped.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MSHADE) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[MSHADE-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MSHADE-XXX` with the appropriate JIRA issue. Best
practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
