ascheman commented on code in PR #49:
URL: https://github.com/apache/maven-sources/pull/49#discussion_r3666337569


##########
default.xml:
##########
@@ -155,6 +155,7 @@
   <project path='svn/doxia-ide'                             
name='maven-doxia-ide.git'           revision='trunk' />
 
   <project path='plexus/codehaus-plexus.github.io'          
name='codehaus-plexus.github.io.git' remote='plexus' revision='source' />
+  <project path='plexus/github'                             name='.github.git' 
                  remote='plexus' />

Review Comment:
   Thanks, but this is intentional. Omitting `revision` is the norm in this 
manifest, not the exception: 107 of 135 entries (and 17 of the 18 `plexus/*` 
entries) carry no `revision` and deliberately track the remote's default 
branch. The single `plexus/*` entry that pins one — `codehaus-plexus.github.io` 
with `revision='source'` — does so precisely because its content lives on a 
non-default branch.
   
   `codehaus-plexus/.github` is tracked on its default branch (`master`), so 
omitting `revision` here is the consistent and correct choice; adding one would 
make this entry the odd one out. Keeping it as-is.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to