wilx opened a new pull request, #1342:
URL: https://github.com/apache/maven-assembly-plugin/pull/1342
Fixes #1306.
## Summary
Use the repositories configured for the project being assembled when the
Assembly Plugin rebuilds dependency projects to obtain their POM metadata.
This prevents Maven 3 from repeatedly warning that a locally cached
dependency
POM came from a repository unavailable in the current build context when that
repository is declared by the assembly project rather than in the session's
initial project-building request.
## Root cause
`AddDependencySetsTask` creates a `ProjectBuildingRequest` for each
dependency
by copying the Maven session request. That copied request does not
necessarily
contain repositories contributed by the effective assembly project. Maven
therefore attempted to verify the dependency POM against Central alone,
emitted the unavailable-repository warning, and fell back to a stub project.
The copied request now uses `project.getRemoteArtifactRepositories()`,
retaining
the repositories Maven calculated for the project being assembled.
The unit test verifies that these repositories reach `ProjectBuilder`. The
new
Invoker project creates a dependency in a private file repository, verifies
that the warning is absent, and checks that the dependency JAR remains
present
in the resulting archive. Before the implementation change, this integration
test failed because the warning appeared twice.
## Compatibility and verification
- Maven 3.9.16 with Java 21: `mvn clean verify` passed with 268 unit tests.
- Maven 3.9.16 with Java 21: the focused MASSEMBLY-1306 Invoker test passed.
- Maven 4.0.0-rc-5 with Java 21: the focused MASSEMBLY-1306 Invoker test
passed.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in
other changes.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
Note that commits might be squashed by a maintainer on merge.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [x] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
