gnodet commented on PR #12535:
URL: https://github.com/apache/maven/pull/12535#issuecomment-5089094800
Addressed both points from the re-review:
1. **`filterByScope` test coverage** — Added three unit tests in
`BuildPlanCreatorTest`:
- `testFilterByScopeNullReturnsAll` — verifies null/empty scope returns
all upstream projects
- `testFilterByScopeMatchesExact` — verifies exact scope matching with
compile, provided, test, and null-scoped (default=compile) dependencies
- `testFilterByScopeExcludesNonDependencies` — verifies upstream projects
not declared as dependencies are excluded
Made `filterByScope` package-private (was `private static`) so the test
can call it directly.
2. **`provided`-scoped reactor deps behavioral note** — Added Javadoc to
`filterByScope` explicitly documenting that matching is exact on the declared
scope string and does _not_ perform path-scope resolution (e.g. filtering by
`"compile"` won't include `"provided"` even though `PathScope.MAIN_COMPILE`
encompasses both). This keeps the filter simple and predictable; broader
scope-aware filtering can be added as a follow-up if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
