ascheman commented on PR #634: URL: https://github.com/apache/maven-war-plugin/pull/634#issuecomment-5085776961
> PTAL @elharo No new commit landed (head still `e8f0732439`), so the `||` short-circuit is unchanged. The ask: pull the three `set*` calls out of the `if` and apply all three unconditionally, then log if any failed. Re-review as soon as it's in — thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
