slawekjaranowski commented on code in PR #160:
URL: 
https://github.com/apache/maven-toolchains-plugin/pull/160#discussion_r3574062430


##########
src/main/java/org/apache/maven/plugins/toolchain/ToolchainConverter.java:
##########
@@ -55,20 +59,13 @@ public Object fromConfiguration(
             Class baseType,
             ClassLoader classLoader,
             ExpressionEvaluator expressionEvaluator,
-            ConfigurationListener listener)
-            throws ComponentConfigurationException {
+            ConfigurationListener listener) {
         ToolchainsRequirement retValue = new ToolchainsRequirement();
-
-        processConfiguration(retValue, configuration, expressionEvaluator);
-
+        processConfiguration(retValue, configuration);
         return retValue;
     }
 
-    private void processConfiguration(
-            ToolchainsRequirement requirement,
-            PlexusConfiguration configuration,
-            ExpressionEvaluator expressionEvaluator)
-            throws ComponentConfigurationException {
+    private void processConfiguration(ToolchainsRequirement requirement, 
PlexusConfiguration configuration) {

Review Comment:
   extends IT to confirm



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to