ctubbsii commented on code in PR #584:
URL:
https://github.com/apache/maven-apache-parent/pull/584#discussion_r3502423052
##########
pom.xml:
##########
@@ -526,6 +532,38 @@ under the License.
</build>
</profile>
<!-- END SNIPPET: release-profile -->
+ <profile>
+ <id>push-to-atr</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.tooling</groupId>
+ <artifactId>atr-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>atr-check-composing</id>
+ <goals>
+ <goal>check-composing</goal>
+ </goals>
+ </execution>
+ <execution>
+ <id>upload-to-atr</id>
+ <goals>
+ <goal>upload</goal>
+ </goals>
+ <configuration>
+ <files>
+
<file>${project.build.directory}/${project.artifactId}-${project.version}-source-release.zip</file>
Review Comment:
I realize this is already merged and I'm late to review, but hard-coding the
paths to upload in the plugin config seems like a problem if the hard-coded
path is a zip file. zip files don't preserve POSIX execute bits on scripts and
other contents, so many projects create a source-release tarball instead, which
is configurable in the maven-release-plugin configuration in this parent POM.
Any ATR plugin profile should also be similarly capable of being able to handle
that.
##########
pom.xml:
##########
@@ -526,6 +532,38 @@ under the License.
</build>
</profile>
<!-- END SNIPPET: release-profile -->
+ <profile>
+ <id>push-to-atr</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.tooling</groupId>
+ <artifactId>atr-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>atr-check-composing</id>
+ <goals>
+ <goal>check-composing</goal>
+ </goals>
+ </execution>
+ <execution>
+ <id>upload-to-atr</id>
+ <goals>
+ <goal>upload</goal>
+ </goals>
+ <configuration>
+ <files>
+
<file>${project.build.directory}/${project.artifactId}-${project.version}-source-release.zip</file>
+
<file>${project.build.directory}/${project.artifactId}-${project.version}-source-release.zip.sha512</file>
Review Comment:
Is this supposed to be the sha512 generated by the
net.nicoulaj.maven.plugins:checksum-maven-plugin ? That plugin generates
checksums for all artifacts with the classifier `source-release`, not a
specific `source-release` zip file. This plugin config makes a lot of
assumptions about the file name of the source-release artifact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
