seregamorph commented on PR #1938: URL: https://github.com/apache/maven-resolver/pull/1938#issuecomment-4825881088
Few comments: * indeed, the number of nested recursive calls inside of `gatherCRNodes` is high, but there is no StackOverflowError (as it happens with way deeper stack), it just means that if the complexity is high in each nested iteration, this can lead to OOM/high CPU while traversing too many tree elements * The `build hang` - almost agree there is not caused by this particular PR, but still deserves attention 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
