desruisseaux commented on code in PR #11857:
URL: https://github.com/apache/maven/pull/11857#discussion_r3292575014
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/PathModularization.java:
##########
@@ -236,7 +236,7 @@ public JavaPathType getPathType() {
/**
* If the module has no name, adds the filename of the JAR file in the
given collection.
* This method should be invoked for dependencies placed on {@link
JavaPathType#MODULES}
Review Comment:
Rewriting as below:
```java
/**
* If the JAR has no {@code module-info.class} entry and no {@code
Automatic-Module-Name}
* attribute in JAR's manifest, adds the filename of the JAR file in the
given collection.
* This method should be invoked for all dependencies placed on the
module-path,
* e.g. all dependencies of type {@link JavaPathType#MODULES}.
* If the module described by the {@code PathModularization} instance
has an explicit name
* either with a {@code module-info.class} file or with an {@code
"Automatic-Module-Name"}
* attribute in the {@code META-INF/MANIFEST.MF} file, then this method
does nothing.
* Otherwise, this method adds an element in the given {@code
automodulesDetected} collection.
* That collection will be used later for preparing a warning message.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
