gnodet commented on code in PR #11743:
URL: https://github.com/apache/maven/pull/11743#discussion_r3284339267
##########
impl/maven-cli/pom.xml:
##########
@@ -308,6 +308,7 @@ under the License.
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
+ <argLine>-Xmx256m @{jacocoArgLine}
-javaagent:${org.mockito:mockito-core:jar}</argLine>
Review Comment:
This hardcodes the argLine at the module level, bypassing the parent pom's
`mockito` profile mechanism (root pom lines 942-961). The parent already has
`maven-dependency-plugin:properties` + a profile that adds
`-javaagent:${org.mockito:mockito-core:jar}` to surefire.
If the parent mechanism doesn't work here, it would be better to fix it at
the parent level. Also note that the parent's `mockito` profile (line 955)
itself drops `@{jacocoArgLine}` — that's a pre-existing bug worth fixing
regardless.
##########
impl/maven-cli/src/test/java/org/apache/maven/cling/invoker/mvnup/goals/MockitoAgentConfigurationTest.java:
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.cling.invoker.mvnup.goals;
+
+import java.lang.management.ManagementFactory;
+import java.util.List;
+
+import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+@DisplayName("Mockito agent configuration")
+class MockitoAgentConfigurationTest {
+
+ @Test
+ @DisplayName("should run tests with mockito configured as javaagent")
+ void shouldRunTestsWithMockitoAsJavaAgent() {
+ List<String> inputArguments =
ManagementFactory.getRuntimeMXBean().getInputArguments();
+
+ assertTrue(
+ inputArguments.stream().anyMatch(a ->
a.startsWith("-javaagent:") && a.contains("mockito-core")),
+ () -> "Expected Mockito javaagent in JVM arguments, but got: "
+ inputArguments);
+ }
+}
Review Comment:
This test only verifies build infrastructure (that the javaagent JVM flag is
present). It doesn't test any production code. If the mockito agent were
missing, any test using `Mockito.mock()` on a non-interface would already fail
with a clear error, making this test redundant.
I'd suggest removing this file — the real fix is just the surefire
configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
