Bukama commented on PR #363:
URL: 
https://github.com/apache/maven-help-plugin/pull/363#issuecomment-4490564846

   ```
   Apache Maven 4.0.0-rc-5 (fb3ecaef88106acb40467a450248dfdbd75f3b35)
   Maven home: C:\apache-maven-4.0.0-rc-5
   Java version: 25.0.2, vendor: Azul Systems, Inc., runtime: C:\Program 
Files\Zulu\zulu-25
   Default locale: de_DE, platform encoding: UTF-8
   OS name: "windows 11", version: "10.0", arch: "amd64", family: "winnt"
   
   [INFO] Build Summary:
   [INFO]   Passed: 32, Failed: 1, Errors: 0, Skipped: 2
   [INFO] -------------------------------------------------
   [ERROR] The following builds failed:
   [ERROR] *  effective-pom_properties\pom.xml
   [INFO] -------------------------------------------------
   [WARNING] The following builds were skipped:
   [WARNING] *  evaluate-forceStdout\pom.xml
   [WARNING] *  evaluate-settings-servers\pom.xml
   ```
   
   I think the failing tests has to do with the line seperators as they dont 
get escaped in the regex and therefore do not match the expected output. The 
foollowing is listed in the output
   
   ```
   <properties>\r\n    <maven.compiler.target>1.6</maven.compiler.target>\r\n   
 <maven.compiler.source>1.6</maven.compiler.source>\r\n    
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>\r\n    
<project.build.outputTimestamp>1980-02-01T00:00:00Z</project.build.outputTimestamp>\r\n
    
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>\r\n  
</properties>
   ```
   
   I'm not sure if we care about the line breaks, but if we only compare about 
the comparision of the two properties than we could change the test to
   
   ```
   String content = new File( basedir, "build.log" ).text
   assert content.exists()
   assert content.contains( 
"<maven.compiler.target>1.6</maven.compiler.target>" )
   assert content.contains( 
"<maven.compiler.source>1.6</maven.compiler.source>" )
   ```
   
   This would also make the test independent of the order of the properties.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to