Copilot commented on code in PR #1564:
URL: https://github.com/apache/maven-site/pull/1564#discussion_r3139653204
##########
content/resources/xsd/maven-4.0.0.xsd:
##########
@@ -107,7 +107,7 @@
<xs:element minOccurs="0" name="name" type="xs:string">
<xs:annotation>
<xs:documentation source="version">3.0.0+</xs:documentation>
- <xs:documentation source="description">The full name of the
project.</xs:documentation>
+ <xs:documentation source="description">The full name of the project.
If not specified aretifactId will be used.</xs:documentation>
Review Comment:
There is a typo in the documentation text: "aretifactId" should be
"artifactId" (and the sentence reads awkwardly without an article, e.g., "the
artifactId").
```suggestion
<xs:documentation source="description">The full name of the
project. If not specified, the artifactId will be used.</xs:documentation>
```
##########
content/resources/xsd/maven-4.0.0.xsd:
##########
@@ -1623,7 +1623,7 @@
parameters or command line arguments.</xs:documentation>
</xs:annotation>
<xs:all>
- <xs:element minOccurs="0" name="id" type="xs:string" default="default">
+ <xs:element name="id" type="xs:string" default="default">
Review Comment:
`Profile` now requires an `<id>` element but still declares
`default="default"`. If the element is required, the default attribute is
redundant/misleading; either remove the default or keep the element optional if
a default value is intended.
```suggestion
<xs:element name="id" type="xs:string">
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
