kwin commented on code in PR #1261:
URL:
https://github.com/apache/maven-site-plugin/pull/1261#discussion_r3072310894
##########
src/main/java/org/apache/maven/plugins/site/render/AbstractSiteRenderingMojo.java:
##########
@@ -320,13 +329,20 @@ protected SiteRenderingContext
createSiteRenderingContext(Locale locale)
// Generate static site
context.setRootDirectory(project.getBasedir());
+ final SiteDirectory mainSiteDirectory;
if (!locale.equals(SiteTool.DEFAULT_LOCALE)) {
- context.addSiteDirectory(new SiteDirectory(new File(siteDirectory,
locale.toString()), true));
+ mainSiteDirectory = new SiteDirectory(new File(this.siteDirectory,
locale.toString()), true);
context.addSiteDirectory(new SiteDirectory(new
File(generatedSiteDirectory, locale.toString()), false));
} else {
- context.addSiteDirectory(new SiteDirectory(siteDirectory, true));
+ mainSiteDirectory = new SiteDirectory(siteDirectory, true);
context.addSiteDirectory(new SiteDirectory(generatedSiteDirectory,
false));
}
+ if (alternativeSiteSourceDirectories != null) {
+ for (File additionalSiteSourceDirectory :
alternativeSiteSourceDirectories) {
+
mainSiteDirectory.addAlternativeEditableSourceDirectory(additionalSiteSourceDirectory);
+ }
+ }
+ context.addSiteDirectory(mainSiteDirectory);
Review Comment:
Can you clarify what is the concern here? The site directory just got an
additional field (locale is not touched).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
