gnodet opened a new pull request, #11929: URL: https://github.com/apache/maven/pull/11929
## Summary - Fix `DefaultSettingsXmlFactory.write()` to default `addLocationInformation` to `false` and only enable it when an explicit `inputLocationFormatter` is provided via `XmlWriterRequest`, matching the existing behavior of `DefaultModelXmlFactory.write()` - Apply the same fix to `DefaultToolchainsXmlFactory.write()` which had the identical bug - Add tests verifying that location comments are suppressed by default and only emitted when a formatter is explicitly provided Closes #11899 ## Test plan - [x] New `DefaultSettingsXmlFactoryTest` verifies no location comments without formatter - [x] New `DefaultSettingsXmlFactoryTest` verifies location comments appear with explicit formatter - [x] All 459 existing tests in `maven-impl` pass _Claude Code on behalf of Guillaume Nodet_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
