cstamas commented on code in PR #11916:
URL: https://github.com/apache/maven/pull/11916#discussion_r3065378595
##########
maven-core/src/main/java/org/apache/maven/eventspy/internal/EventSpyDispatcher.java:
##########
@@ -18,32 +18,33 @@
*/
package org.apache.maven.eventspy.internal;
-import java.util.ArrayList;
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
import java.util.List;
import org.apache.maven.eventspy.EventSpy;
import org.apache.maven.execution.ExecutionListener;
-import org.codehaus.plexus.component.annotations.Component;
-import org.codehaus.plexus.component.annotations.Requirement;
-import org.codehaus.plexus.logging.Logger;
import org.eclipse.aether.RepositoryListener;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
* Dispatches callbacks to all registered eventspies.
* @since 3.0.2
*/
-@Component(role = EventSpyDispatcher.class)
+@Singleton
+@Named
public class EventSpyDispatcher {
- @Requirement
- private Logger logger;
+ private final Logger logger = LoggerFactory.getLogger(getClass());
- @Requirement(role = EventSpy.class)
- private List<EventSpy> eventSpies;
+ private final List<EventSpy> eventSpies;
- public void setEventSpies(List<EventSpy> eventSpies) {
- // make copy to get rid of needless overhead for dynamic lookups
- this.eventSpies = new ArrayList<>(eventSpies);
+ @Inject
+ public EventSpyDispatcher(List<EventSpy> eventSpies) {
+ this.eventSpies = eventSpies;
}
Review Comment:
Coz it had setter and ctor and used field injection and it was confusing.
This is really internal component, so here i did not care.
We can undo it somehow, if must.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
