Make wagon lookup case-insensitive with regard to protocol
----------------------------------------------------------

                 Key: MARTIFACT-8
                 URL: http://jira.codehaus.org/browse/MARTIFACT-8
             Project: Maven Artifact
          Issue Type: Bug
         Environment: Maven 2.0.8
            Reporter: Benjamin Bentmann
            Priority: Minor
         Attachments: case-insensitive-lookup.patch

>From [RFC 2396|http://www.ietf.org/rfc/rfc2396.txt], section 3.1, "Scheme 
>Component":
bq. [...] programs interpreting URI should treat upper case letters as 
equivalent to lower case in scheme names (e.g., allow "HTTP" as well as "http").

Currently, the lookup of a wagon fails if the protocol is not completely lower 
case which deviates from the RFC, the implementation of java.net.URL/URI and 
everyday experience of users. The attached patch fixes this by normalizing the 
protocol to lower case before lookup. Porting this fix to other branches or 
WagonManagers is left to the reviewer.

Please note the implication of this patch for wagon providers: Any provider 
that does not use an all lower case role-hint for the registration with Plexus 
cannot be lookuped. As far as I can see, this is no problem with the existing 
providers. 


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to