slawekjaranowski commented on code in PR #353:
URL:
https://github.com/apache/maven-antrun-plugin/pull/353#discussion_r2678580309
##########
pom.xml:
##########
@@ -219,6 +215,16 @@ under the License.
<!-- </execution> -->
</executions>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-invoker-plugin</artifactId>
+ <configuration>
+ <properties>
+ <maven.compiler.source>${javaVersion}</maven.compiler.source>
+ <maven.compiler.target>${javaVersion}</maven.compiler.target>
+ </properties>
+ </configuration>
+ </plugin>
Review Comment:
ok, in parents 36, 46 we set `maven.compiler.*` according to JDK used to
build
https://maven.apache.org/pom/asf/
> They will be set automatically according to the JDK used for the project
build:
> for JDK 8 and older
> <maven.compiler.source>${javaVersion}</maven.compiler.source>
> <maven.compiler.target>${javaVersion}</maven.compiler.target>
>for JDK 9 and newer
> <maven.compiler.release>${javaVersion}</maven.compiler.release>
if really needed we should follow the same here
but I think that we simply should use newer version on m-compiler-p in ITs,
so we need set version for plugin in ITs like:
```
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>@version.maven-compiler-plugin@</version>
</plugin>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
