Giovds commented on code in PR #353: URL: https://github.com/apache/maven-help-plugin/pull/353#discussion_r2676336142
########## src/main/java/org/apache/maven/plugins/help/EffectiveMojoUtils.java: ########## @@ -20,66 +20,40 @@ import javax.xml.XMLConstants; -import java.io.File; import java.io.IOException; import java.io.StringReader; import java.io.StringWriter; -import java.io.Writer; -import java.nio.file.Files; import java.util.ArrayList; import java.util.Collections; import java.util.LinkedHashSet; import java.util.List; import java.util.Properties; import java.util.Set; -import org.apache.maven.project.ProjectBuilder; import org.codehaus.plexus.util.xml.XMLWriter; import org.codehaus.plexus.util.xml.XmlWriterUtil; -import org.eclipse.aether.RepositorySystem; import org.jdom2.Document; import org.jdom2.JDOMException; import org.jdom2.input.SAXBuilder; import org.jdom2.output.Format; import org.jdom2.output.XMLOutputter; /** - * Base class with common utilities to write effective Pom/settings. + * Utility class with common utilities to write effective Pom/settings. * * @author <a href="mailto:[email protected]";>Vincent Siveton</a> * @since 2.1 */ -public abstract class AbstractEffectiveMojo extends AbstractHelpMojo { Review Comment: Is this an agreement on all ASF repo's? I thought this was mainly for maven-core API's. I don't know, but do ASF-plugins support extensions of plugin public API's, do people do this? A quick search on GitHub on this class only seems to result in forks. Alternatively I can e.g. deprecate it and change the implementation to point to the new class. When will it be removed, and does this require a new ticket? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
