rmannibucau commented on PR #1566: URL: https://github.com/apache/maven-dependency-plugin/pull/1566#issuecomment-3675638809
1. well this is discussable even if I agree on the intent, but the code pattern you do use is also wrong for try blocks cause it misses the flush (in terms of "cleaness", luckily this does nothing there but if you assume that you can also assume there will never be any IOException) which is a well know issue of the return within the try so looks worse than before to me 2. not a fan of coding for an hypothesis, there is literally not a single line throwing that exception in the related class so it is impossible and other exceptions will blow up as expected so tempted to think this PR is not cleaner so really +-0 since it will literally just add dead code and not change the behavior -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
