gnodet commented on code in PR #11505:
URL: https://github.com/apache/maven/pull/11505#discussion_r2622241004
##########
impl/maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java:
##########
@@ -680,6 +682,13 @@ private void initProject(MavenProject project,
ModelBuilderResult result) {
} else {
hasTest |= ProjectScope.TEST.equals(scope);
}
+ } else if (Language.RESOURCES.equals(language)) {
+ ProjectScope scope = src.scope();
+ if (ProjectScope.MAIN.equals(scope)) {
Review Comment:
The code looks weird. We should use
```
if (ProjectScope.MAIN.equals(scope)) {
hasMainResources = true;
} else if (ProjectScope.TEST.equals(scope)) {
hasTestResources = true;
}
```
or
```
hasMainResources |= ProjectScope.MAINequals(scope);
hasTestResources |= ProjectScope.TEST.equals(scope);
```
but this mix is not very clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
