gnodet commented on code in PR #1709:
URL: https://github.com/apache/maven-resolver/pull/1709#discussion_r2610825478
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/filter/GroupIdRemoteRepositoryFilterSource.java:
##########
@@ -125,14 +122,31 @@ public final class GroupIdRemoteRepositoryFilterSource
extends RemoteRepositoryF
public static final boolean DEFAULT_SKIPPED = false;
+ /**
+ * The "no input outcome": if filter is enabled, but no input is
available. By default, RRF filters without
+ * input would "stand aside" and just "allow", resulting in same outcome
for "disabled" and "enabled but no input
+ * available" situations. This configuration allows to alter outcome for
"enabled but no input available" case.
Review Comment:
```suggestion
* Determines what happens when the filter is enabled but has no prefix
data to work with.
* When set to `true` (default), the filter allows all requests to
proceed. When set to `false`,
* the filter blocks requests when no prefix data is available.
```
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/filter/GroupIdRemoteRepositoryFilterSource.java:
##########
@@ -125,14 +122,31 @@ public final class GroupIdRemoteRepositoryFilterSource
extends RemoteRepositoryF
public static final boolean DEFAULT_SKIPPED = false;
+ /**
+ * The "no input outcome": if filter is enabled, but no input is
available. By default, RRF filters without
+ * input would "stand aside" and just "allow", resulting in same outcome
for "disabled" and "enabled but no input
+ * available" situations. This configuration allows to alter outcome for
"enabled but no input available" case.
Review Comment:
```suggestion
* Determines what happens when the filter is enabled but has no prefix
data to work with.
* When set to `true` (default), the filter allows all requests to
proceed. When set to `false`,
* the filter blocks requests when no prefix data is available.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
