elharo commented on code in PR #1477:
URL: https://github.com/apache/maven-site/pull/1477#discussion_r2606660010
##########
content/markdown/whatsnewinmaven4.md:
##########
@@ -81,6 +81,10 @@ The consumer POM is a **flattened** version of the build
POM, meaning:
This flattening ensures that consumers of your artifact have all the
information they need without requiring access to
parent POMs or understanding the internal structure of your multi-project
build.
+The flatten feature is disabled by default to avoid unexpected behavior and
better control about listing (transitive) dependencies in consumer POM.
Review Comment:
the consume POM.
better control about --> better control of
I'm also not sure that what's really going on here is control of listing the
dependencies or control of the dependencies
##########
content/markdown/whatsnewinmaven4.md:
##########
@@ -81,6 +81,10 @@ The consumer POM is a **flattened** version of the build
POM, meaning:
This flattening ensures that consumers of your artifact have all the
information they need without requiring access to
parent POMs or understanding the internal structure of your multi-project
build.
+The flatten feature is disabled by default to avoid unexpected behavior and
better control about listing (transitive) dependencies in consumer POM.
+To enable a flattened consumer POM the user property
`maven.consumer.pom.flatten` property must be set to `true`.
+User properties can be controlled using
`${session.rootDirectory}/.mvn/maven-user.properties` for a per-reactor
configuration though.
Review Comment:
delete though
##########
content/markdown/whatsnewinmaven4.md:
##########
@@ -81,6 +81,10 @@ The consumer POM is a **flattened** version of the build
POM, meaning:
This flattening ensures that consumers of your artifact have all the
information they need without requiring access to
parent POMs or understanding the internal structure of your multi-project
build.
+The flatten feature is disabled by default to avoid unexpected behavior and
better control about listing (transitive) dependencies in consumer POM.
+To enable a flattened consumer POM the user property
`maven.consumer.pom.flatten` property must be set to `true`.
Review Comment:
To enable a flattened consumer POM --> To publish a flattened consumer POM
instead of the full build POM,
##########
content/markdown/whatsnewinmaven4.md:
##########
@@ -67,7 +67,7 @@ article [Introduction to Maven Toolchains][8] by Maven
maintainer Maarten Mulder
### Consumer POM
-Maven 4 generates a stripped down consumer POM that removes build information
not needed by consumers, and deploys this
+Maven 4 can generate a stripped down consumer POM that removes build
information not needed by consumers, and deploys this
to the remote repository.
It does not deploy the `pom.xml` used to build the project.
Review Comment:
what happens when the consumer is building a dependent project?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
