desruisseaux commented on code in PR #1002:
URL:
https://github.com/apache/maven-compiler-plugin/pull/1002#discussion_r2597691677
##########
src/main/java/org/apache/maven/plugin/compiler/ToolExecutor.java:
##########
@@ -577,31 +630,52 @@ public boolean compile(final JavaCompiler compiler, final
Options configuration,
if (!generatedSourceDirectories.isEmpty()) {
fileManager.setLocationFromPaths(StandardLocation.SOURCE_OUTPUT,
generatedSourceDirectories);
}
+ final String moduleNameFromPackageHierarchy =
moduleNameFromPackageHierarchy();
Review Comment:
Invalid. Once set to `true`, those variables need to stay `true` for all
subsequent iterations. Either a project is fully modular for all source at all
versions, or fully class-path for all versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
