TheRealHaui commented on code in PR #11509:
URL: https://github.com/apache/maven/pull/11509#discussion_r2593626318
##########
impl/maven-xml/src/test/java/org/apache/maven/internal/xml/XmlNodeBuilderTest.java:
##########
@@ -44,6 +46,10 @@ public int read(char[] cbuf, int off, int len) throws
IOException {
XmlNode node1 = XmlService.read(r);
XmlNode node2 = XmlService.read(r);
assertEquals(node1, node2);
+
+ node1 = XmlService.read(new
ByteArrayInputStream(doc.getBytes(StandardCharsets.UTF_8)), null);
Review Comment:
The re-use of the variables is in no whatsoever way hidden/not visible in
the code.
Therefore, I think this can be considered to not lead to any problems on
developers sides because it gets overseen by them.
And as it is common in program code that variables get re-used/assigned new
values I see no whatsoever problem actually to be honest.
Nonetheless, changed the code and pushed the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
