cstamas commented on code in PR #1694:
URL: https://github.com/apache/maven-resolver/pull/1694#discussion_r2571541543
##########
maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/filter/ruletree/GroupTreeTest.java:
##########
@@ -50,5 +50,59 @@ void smoke() {
assertTrue(groupTree.acceptedGroupId("org.apache.baz"));
assertFalse(groupTree.acceptedGroupId("org.apache.baz.aaa"));
+
+ assertFalse(groupTree.acceptedGroupId("not.in.list.but.uses.default"));
+ }
+
+ @Test
+ void smokeWithPositiveDefault() {
+ GroupTree groupTree = new GroupTree("root");
+ groupTree.loadNodes(Stream.of(
+ "# comment",
+ "",
+ "org.apache.maven",
+ "!=org.apache.maven.foo",
+ "!org.apache.maven.bar",
+ "=org.apache.baz",
+ "*"));
+ assertTrue(groupTree.acceptedGroupId("org.apache.maven"));
+ assertTrue(groupTree.acceptedGroupId("org.apache.maven.aaa"));
+
+ assertFalse(groupTree.acceptedGroupId("org.apache.maven.foo"));
+ assertTrue(groupTree.acceptedGroupId("org.apache.maven.foo.aaa"));
+
+ assertFalse(groupTree.acceptedGroupId("org.apache.maven.bar"));
+ assertFalse(groupTree.acceptedGroupId("org.apache.maven.bar.aaa"));
+
+ assertTrue(groupTree.acceptedGroupId("org.apache.baz"));
+ assertFalse(groupTree.acceptedGroupId("org.apache.baz.aaa"));
Review Comment:
We have a problem here.
Applicable rules:
```
=org.apache.baz
*
```
1st: "allow `org.apache.baz` ONLY"
2nd: default to ALLOW
So why is then `org.apache.baz.aaa` rejected?
Seems the mod `=` causes some issues....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
