slawekjaranowski commented on code in PR #1430:
URL: https://github.com/apache/maven-release/pull/1430#discussion_r2569576759
##########
maven-release-policies/maven-release-semver-policy/src/main/java/org/apache/maven/shared/release/policy/semver/AbstarctSemVerVersionPolicy.java:
##########
@@ -31,19 +30,19 @@
*/
abstract class AbstarctSemVerVersionPolicy implements VersionPolicy {
- protected Version createVersionFromRequest(VersionPolicyRequest request)
throws VersionParseException {
+ protected SemVer createVersionFromRequest(VersionPolicyRequest request)
throws VersionParseException {
try {
- return Version.parse(request.getVersion());
+ return SemVer.parse(request.getVersion());
} catch (IllegalArgumentException e) {
throw new VersionParseException(e.getMessage());
}
}
- protected VersionPolicyResult createResult(Version version) {
+ protected VersionPolicyResult createResult(SemVer version) {
return new VersionPolicyResult().setVersion(version.toString());
}
- protected VersionPolicyResult createSnapshotResult(Version version) {
+ protected VersionPolicyResult createSnapshotResult(SemVer version) {
return new VersionPolicyResult().setVersion(version.toString() +
"-SNAPSHOT");
Review Comment:
`toSnapshotVersion` method should be used here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
