Bukama commented on code in PR #191:
URL: https://github.com/apache/maven-ejb-plugin/pull/191#discussion_r2553265159
##########
src/test/java/org/apache/maven/plugins/ejb/stub/MavenProjectBuildStub.java:
##########
@@ -107,38 +90,16 @@ public void addFile(String name, int type) {
}
}
- public void addFile(String name, String data, int type) {
- File fileName = new File(name);
-
- addFile(name, type);
- dataMap.put(fileName.getName(), data);
- }
-
public String getOutputDirectory() {
return outputDirectory;
}
- public String getTestOutputDirectory() {
- return testOutputDirectory;
- }
-
- public String getResourcesDirectory() {
- return resourcesDirectory;
- }
-
- public String getTestResourcesDirectory() {
- return testResourcesDirectory;
- }
-
public Build getBuild() {
return build;
}
/**
- * returns true if the path is relative and false if absolute also returns
false if it is relative to the parent
- *
- * @param path
- * @return
+ * @return true if the path is relative and false if absolute also returns
false if it is relative to the parent
Review Comment:
Inline returns has bracers at the start and end of line (final dot is
automatically added at inline return). But this needs Java 16, which we don't
use yet for EJB plugin.
But this method has a parameter, so inline return statement is not
applicable.
So this Javadoc should needs a useful description, a parameter description
and the return description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
