sultan commented on PR #1683:
URL: https://github.com/apache/maven-resolver/pull/1683#issuecomment-3559708073
Draft asking for help/reviewer :
What is the intention with this test ?
```
org.opentest4j.AssertionFailedError: expected ga.ga.foo < foo ==>
org.opentest4j.AssertionFailedError: expected 1.0.0-ga-foo < 1-foo ==>
```
```java
@Test
void testEdgeCase_1_2() {
// as expected
assertOrder(X_LT_Y, "ga.ga.foo", "foo");
}
@Test
void testEdgeCase_2_1() {
assertOrder(X_GT_Y, "0.foo.1.2.3", "foo.1.2.3");
// they were equal in Resolver 1.x
assertOrder(X_GT_Y, "0.foo", "foo");
assertOrder(X_EQ_Y, "1.0.0-foo", "1-foo");
// but "foo" != "ga" (string > qualifier)
assertOrder(X_LT_Y, "1.0.0-ga-foo", "1-foo");
assertOrder(X_EQ_Y, "1.0.0-ga-foo", "1-ga-foo");
assertOrder(X_LT_Y, "1.0.0.final-foo", "1-foo");
assertOrder(X_EQ_Y, "1.0.0.final-foo", "1-final-foo");
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
